Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Extract the parser into a crate #2409

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Extract the parser into a crate #2409

wants to merge 4 commits into from

Conversation

jedel1043
Copy link
Member

Depends on #2408.

This finally separates parsing from execution, which should make compilations a bit faster.

@jedel1043 jedel1043 added dependencies Pull requests that update a dependency file parser Issues surrounding the parser lexer Issues surrounding the lexer API labels Nov 5, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Nov 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,500 69,500 0
Ignored 18,422 18,422 0
Failed 5,867 5,867 0
Panics 0 0 0
Conformance 74.10% 74.10% 0.00%

@codecov
Copy link

codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Merging #2409 (dc8f1e3) into main (23f0335) will increase coverage by 0.41%.
The diff coverage is 14.11%.

@@            Coverage Diff             @@
##             main    #2409      +/-   ##
==========================================
+ Coverage   38.33%   38.74%   +0.41%     
==========================================
  Files         313      313              
  Lines       23859    23856       -3     
==========================================
+ Hits         9146     9244      +98     
+ Misses      14713    14612     -101
Impacted Files Coverage Δ
boa_cli/src/main.rs 5.55% <0.00%> (ø)
boa_engine/src/builtins/eval/mod.rs 8.88% <0.00%> (-1.64%) ⬇️
boa_engine/src/builtins/function/mod.rs 24.21% <ø> (-0.79%) ⬇️
boa_engine/src/builtins/regexp/mod.rs 66.12% <ø> (+0.27%) ⬆️
boa_engine/src/lib.rs 76.92% <ø> (ø)
boa_examples/src/bin/commuter_visitor.rs 0.00% <ø> (ø)
boa_examples/src/bin/symbol_visitor.rs 0.00% <ø> (ø)
boa_parser/src/lexer/comment.rs 56.41% <ø> (ø)
boa_parser/src/lexer/cursor.rs 57.48% <ø> (ø)
boa_parser/src/lexer/error.rs 44.44% <ø> (ø)
... and 140 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Razican
Razican reviewed Nov 5, 2022
View reviewed changes
boa_ast/src/operations.rs Outdated Show resolved Hide resolved
boa_ast/src/operations.rs Outdated Show resolved Hide resolved
boa_ast/src/visitor.rs Outdated Show resolved Hide resolved
boa_engine/src/builtins/eval/mod.rs Outdated Show resolved Hide resolved
boa_engine/src/builtins/eval/mod.rs Outdated Show resolved Hide resolved
boa_parser/Cargo.toml Outdated Show resolved Hide resolved
boa_parser/src/parser/mod.rs Show resolved Hide resolved
boa_parser/src/parser/mod.rs Show resolved Hide resolved
@jedel1043
Copy link
Member Author

@Razican most of your comments are for #2408 😅. I'll apply them there, sorry for the confusion!

@jedel1043 jedel1043 requested a review from Razican November 5, 2022 21:46
raskad
raskad approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. Good to get that eval code cleaned up too :)

boa_parser/src/lexer/mod.rs Outdated Show resolved Hide resolved
boa_parser/src/lexer/mod.rs Outdated Show resolved Hide resolved
HalidOdat
HalidOdat approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just a small nitpick :)

boa_parser/Cargo.toml Outdated Show resolved Hide resolved
@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 6, 2022
@jedel1043
Extract the parser into a crate (#2409)
b88736a 
Depends on #2408.

This finally separates parsing from execution, which should make compilations a bit faster.
@bors
Copy link

bors bot commented Nov 6, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Extract the parser into a crate [Merged by Bors] - Extract the parser into a crate Nov 6, 2022
@bors bors bot closed this Nov 6, 2022
@bors bors bot deleted the parser-crate branch November 6, 2022 15:54
@RageKnify RageKnify added the Internal Category for changelog label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
API dependencies Pull requests that update a dependency file Internal Category for changelog lexer Issues surrounding the lexer parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jedel1043 @Razican @HalidOdat @raskad @RageKnify