Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix rust 1.66.0 lints #2486

Closed
wants to merge 3 commits into from
Closed

Conversation

raskad
Copy link
Member

@raskad raskad commented Dec 16, 2022

This Pull Request fixes the new lints introduced in clippy 1.66.0.

@raskad raskad added the Internal Category for changelog label Dec 16, 2022
@raskad raskad added this to the v0.17.0 milestone Dec 16, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,162 94,162 0
Passed 69,710 69,710 0
Ignored 18,771 18,771 0
Failed 5,681 5,681 0
Panics 0 0 0
Conformance 74.03% 74.03% 0.00%

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2486 (5664689) into main (ffce18a) will increase coverage by 0.19%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
+ Coverage   52.53%   52.72%   +0.19%     
==========================================
  Files         333      332       -1     
  Lines       35087    34956     -131     
==========================================
- Hits        18433    18431       -2     
+ Misses      16654    16525     -129     
Impacted Files Coverage Δ
boa_cli/src/main.rs 0.00% <ø> (-1.08%) ⬇️
boa_engine/src/builtins/function/mod.rs 27.66% <0.00%> (ø)
boa_engine/src/vm/flowgraph/color.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/flowgraph/graph.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/flowgraph/mod.rs 0.00% <0.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 60.86% <ø> (ø)
boa_parser/src/parser/expression/mod.rs 91.00% <ø> (ø)
boa_engine/src/lib.rs 100.00% <100.00%> (ø)
boa_engine/src/object/mod.rs 46.17% <0.00%> (-0.11%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you also bump the rustc version? I was planning to use a new lib feature on the Intl PR but I think it would be better to have the bump here, since it's more related.

@jasonwilliams
Copy link
Member

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 17, 2022
This Pull Request fixes the new lints introduced in clippy 1.66.0.
@bors
Copy link

bors bot commented Dec 17, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix rust 1.66.0 lints [Merged by Bors] - Fix rust 1.66.0 lints Dec 17, 2022
@bors bors bot closed this Dec 17, 2022
@bors bors bot deleted the rust-1.66-0-lints branch December 17, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants