-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add early errors for 'eval' or 'arguments' in parameters #2515
Conversation
Test262 conformance changes
Fixed tests (8):
|
Codecov Report
@@ Coverage Diff @@
## main #2515 +/- ##
==========================================
+ Coverage 50.68% 51.52% +0.84%
==========================================
Files 358 353 -5
Lines 36265 35731 -534
==========================================
+ Hits 18380 18411 +31
+ Misses 17885 17320 -565
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
boa_parser/src/parser/expression/primary/async_function_expression/mod.rs
Outdated
Show resolved
Hide resolved
boa_parser/src/parser/expression/primary/async_function_expression/mod.rs
Outdated
Show resolved
Hide resolved
boa_parser/src/parser/expression/primary/async_function_expression/mod.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good!
bors r+ |
This Pull Request changes the following: - Add early errors for functions to make sure that 'eval' or 'arguments' cannot be used as binding identifiers in function parameters. When the function body contains a strict directive, this also has to be accounted for. - Fix early errors for function identifiers to make sure they cannot be 'eval' or 'arguments' when a function body contains a strict directive.
Pull request successfully merged into main. Build succeeded: |
This Pull Request changes the following: