-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - API to construct a NativeFunction
from a native async function
#2542
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2542 +/- ##
==========================================
+ Coverage 49.55% 49.71% +0.16%
==========================================
Files 386 384 -2
Lines 39133 38996 -137
==========================================
- Hits 19391 19386 -5
+ Misses 19742 19610 -132
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
d7e4b4e
to
0c5f9c1
Compare
NativeFunction
from a native async function NativeFunction
from a native async function
0c5f9c1
to
51e2f57
Compare
90048f2
to
36b8eb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect to me! Great work @jedel1043
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 😄
0cf6662
to
d7bc043
Compare
d7bc043
to
a6aa857
Compare
bors r+ |
~~Builds off of #2529.~~ Merged. This Pull Request allows passing any function returning `impl Future<Output = JsResult<JsValue>>` to the `NativeFunction` constructor, allowing native concurrency hooks into the engine. It changes the following: - Adds a `NativeFunction::from_async_fn` function. - Adds a new `JobQueue::enqueue_future_job` method. - Adds an example usage on `boa_examples`.
Pull request successfully merged into main. Build succeeded: |
NativeFunction
from a native async function NativeFunction
from a native async function
Builds off of #2529.Merged.This Pull Request allows passing any function returning
impl Future<Output = JsResult<JsValue>>
to theNativeFunction
constructor, allowing native concurrency hooks into the engine.It changes the following:
NativeFunction::from_async_fn
function.JobQueue::enqueue_future_job
method.boa_examples
.