Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix failing collator tests #2575

Closed
wants to merge 1 commit into from
Closed

Conversation

jedel1043
Copy link
Member

This Pull Request fixes the regressed tests caused by the ICU4X version bump.

@jedel1043 jedel1043 added bug Something isn't working Internal Category for changelog labels Jan 28, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jan 28, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,205 94,205 0
Passed 70,720 70,722 +2
Ignored 18,622 18,622 0
Failed 4,863 4,861 -2
Panics 0 0 0
Conformance 75.07% 75.07% +0.00%
Fixed tests (2):
test/intl402/Collator/usage-de.js [strict mode] (previously Failed)
test/intl402/Collator/usage-de.js (previously Failed)

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #2575 (56aba6c) into main (bd0652f) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2575      +/-   ##
==========================================
+ Coverage   49.99%   50.05%   +0.05%     
==========================================
  Files         380      379       -1     
  Lines       37846    37792      -54     
==========================================
- Hits        18921    18915       -6     
+ Misses      18925    18877      -48     
Impacted Files Coverage Δ
boa_interner/src/lib.rs 80.67% <0.00%> (-3.37%) ⬇️
boa_ast/src/visitor.rs 12.79% <0.00%> (-0.59%) ⬇️
boa_engine/src/object/internal_methods/global.rs 32.58% <0.00%> (-0.45%) ⬇️
boa_examples/src/bin/commuter_visitor.rs 0.00% <0.00%> (ø)
boa_examples/src/bin/classes.rs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Razican
Copy link
Member

Razican commented Jan 29, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jan 29, 2023
This Pull Request fixes the regressed tests caused by the ICU4X version bump.
@bors
Copy link

bors bot commented Jan 29, 2023

Build failed:

@jedel1043
Copy link
Member Author

bors retry

bors bot pushed a commit that referenced this pull request Jan 29, 2023
This Pull Request fixes the regressed tests caused by the ICU4X version bump.
@bors
Copy link

bors bot commented Jan 29, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix failing collator tests [Merged by Bors] - Fix failing collator tests Jan 29, 2023
@bors bors bot closed this Jan 29, 2023
@bors bors bot deleted the fix-collator branch January 29, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants