-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix failing collator tests #2575
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
January 28, 2023 19:19
Test262 conformance changes
Fixed tests (2):
|
Codecov Report
@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
+ Coverage 49.99% 50.05% +0.05%
==========================================
Files 380 379 -1
Lines 37846 37792 -54
==========================================
- Hits 18921 18915 -6
+ Misses 18925 18877 -48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Jan 28, 2023
Razican
approved these changes
Jan 29, 2023
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2023
This Pull Request fixes the regressed tests caused by the ICU4X version bump.
Build failed: |
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2023
This Pull Request fixes the regressed tests caused by the ICU4X version bump.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix failing collator tests
[Merged by Bors] - Fix failing collator tests
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the regressed tests caused by the ICU4X version bump.