Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix exponent operator #2681

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix exponent operator #2681

wants to merge 2 commits into from

Conversation

HalidOdat
Copy link
Member

When abs(base) == 1 and y == +/- Infinity result should be NaN

Fixes the remaining failing tests in the exponentiation test suite

@HalidOdat
Fix exponent operator
0cf78bb 
When abs(base) == 1 and y == +/- Infinity result should be NaN
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 71,990 71,994 +4
Ignored 17,324 17,324 0
Failed 4,963 4,959 -4
Panics 14 14 0
Conformance 76.36% 76.36% +0.00%
Fixed tests (4): 
test/language/expressions/exponentiation/applying-the-exp-operator_A7.js [strict mode] (previously Failed)
test/language/expressions/exponentiation/applying-the-exp-operator_A7.js (previously Failed)
test/language/expressions/exponentiation/applying-the-exp-operator_A8.js [strict mode] (previously Failed)
test/language/expressions/exponentiation/applying-the-exp-operator_A8.js (previously Failed)

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2681 (0cf78bb) into main (da866ca) will increase coverage by 0.23%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
+ Coverage   49.19%   49.42%   +0.23%     
==========================================
  Files         397      394       -3     
  Lines       39739    39527     -212     
==========================================
- Hits        19548    19535      -13     
+ Misses      20191    19992     -199
Impacted Files Coverage Δ
boa_engine/src/value/operations.rs 47.87% <25.00%> (-0.72%) ⬇️

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

boa_engine/src/value/operations.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat marked this pull request as ready for review March 16, 2023 18:52
@HalidOdat HalidOdat requested a review from jedel1043 March 16, 2023 18:52
jedel1043
jedel1043 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedel1043 jedel1043 added this to the v0.17.0 milestone Mar 16, 2023
@jedel1043 jedel1043 added bug Something isn't working execution Issues or PRs related to code execution labels Mar 16, 2023
nekevss
nekevss approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@jedel1043
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 16, 2023
@HalidOdat
Fix exponent operator (#2681)
2588aa9 
When `abs(base) == 1` and `y == +/- Infinity` result should be `NaN`

Fixes the remaining failing tests in the `exponentiation` test suite
@bors
Copy link

bors bot commented Mar 16, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix exponent operator [Merged by Bors] - Fix exponent operator Mar 16, 2023
@bors bors bot closed this Mar 16, 2023
@bors bors bot deleted the fix/exponent-operator branch March 16, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @jedel1043 @nekevss