Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix Object constructor #2694

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix Object constructor #2694

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Mar 20, 2023

This Pull Request changes the following:

  • Add the additional required condition in the Object constructor that checks if the NewTarget is the Object constructor itself.

@raskad raskad added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Mar 20, 2023
@raskad raskad added this to the v0.17.0 milestone Mar 20, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,277 94,277 0
Passed 70,720 70,792 +72
Ignored 17,324 17,324 0
Failed 6,233 6,161 -72
Panics 14 14 0
Conformance 75.01% 75.09% +0.08%
Fixed tests (72): 
test/built-ins/RegExp/S15.10.4.1_A8_T9.js [strict mode] (previously Failed)
test/built-ins/RegExp/S15.10.4.1_A8_T9.js (previously Failed)
test/built-ins/RegExp/prototype/exec/S15.10.6.2_A1_T3.js [strict mode] (previously Failed)
test/built-ins/RegExp/prototype/exec/S15.10.6.2_A1_T3.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A4_T1.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A4_T1.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A4_T3.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A4_T3.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T2.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T2.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T3.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T3.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T7.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T7.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T1.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T1.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T6.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T6.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T1.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T4.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A5_T4.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T5.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T5.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A3_T2.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A3_T2.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A4_T2.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A4_T2.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A3_T1.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A3_T1.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A6_T1.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A6_T1.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A6_T3.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A6_T3.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A3_T3.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A3_T3.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T2.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T2.js (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T3.js [strict mode] (previously Failed)
test/built-ins/Object/S15.2.2.1_A2_T3.js (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A1_T3.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A1_T3.js (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A1_T2.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A1_T2.js (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A1_T1.js [strict mode] (previously Failed)
test/built-ins/Object/prototype/valueOf/S15.2.4.4_A1_T1.js (previously Failed)
test/built-ins/Function/S15.3.2.1_A1_T7.js [strict mode] (previously Failed)
test/built-ins/Function/S15.3.2.1_A1_T7.js (previously Failed)
test/built-ins/String/prototype/concat/S15.5.4.6_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/concat/S15.5.4.6_A1_T1.js (previously Failed)
test/built-ins/String/prototype/lastIndexOf/S15.5.4.8_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/lastIndexOf/S15.5.4.8_A1_T1.js (previously Failed)
test/built-ins/String/prototype/match/this-val-obj.js [strict mode] (previously Failed)
test/built-ins/String/prototype/match/this-val-obj.js (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/search/S15.5.4.12_A1_T1.js (previously Failed)
test/built-ins/String/prototype/charCodeAt/S15.5.4.5_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/charCodeAt/S15.5.4.5_A1_T1.js (previously Failed)
test/built-ins/String/prototype/charAt/S15.5.4.4_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/charAt/S15.5.4.4_A1_T1.js (previously Failed)
test/built-ins/String/prototype/toUpperCase/S15.5.4.18_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/toUpperCase/S15.5.4.18_A1_T1.js (previously Failed)
test/built-ins/String/prototype/substring/S15.5.4.15_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/substring/S15.5.4.15_A1_T1.js (previously Failed)
test/built-ins/String/prototype/replace/S15.5.4.11_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/replace/S15.5.4.11_A1_T1.js (previously Failed)
test/built-ins/String/prototype/indexOf/S15.5.4.7_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/indexOf/S15.5.4.7_A1_T1.js (previously Failed)
test/built-ins/String/prototype/slice/S15.5.4.13_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/slice/S15.5.4.13_A1_T1.js (previously Failed)
test/built-ins/String/prototype/toLowerCase/S15.5.4.16_A1_T1.js [strict mode] (previously Failed)
test/built-ins/String/prototype/toLowerCase/S15.5.4.16_A1_T1.js (previously Failed)

jedel1043
jedel1043 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #2694 (e1075b9) into main (7e6d3c9) will increase coverage by 1.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
+ Coverage   49.36%   50.54%   +1.18%     
==========================================
  Files         397      390       -7     
  Lines       39568    38681     -887     
==========================================
+ Hits        19533    19553      +20     
+ Misses      20035    19128     -907
Impacted Files Coverage Δ
boa_engine/src/builtins/object/mod.rs 60.59% <100.00%> (+0.18%) ⬆️

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Razican
Razican approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Razican
Copy link
Member

Razican commented Mar 20, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 20, 2023
@raskad
Fix Object constructor (#2694)
d794edf 
This Pull Request changes the following:

- Add the additional required condition in the Object constructor that checks if the `NewTarget` is the Object constructor itself.
@bors
Copy link

bors bot commented Mar 20, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix Object constructor [Merged by Bors] - Fix Object constructor Mar 20, 2023
@bors bors bot closed this Mar 20, 2023
@bors bors bot deleted the fix-object-contructor branch March 20, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@nekevss nekevss Awaiting requested review from nekevss

@RageKnify RageKnify Awaiting requested review from RageKnify

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @Razican @jedel1043