[Merged by Bors] - [Merged by Bors] - Fix get function opcode traces #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
HalidOdat
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
+ Coverage 49.44% 50.47% +1.02%
==========================================
Files 395 393 -2
Lines 39693 38857 -836
==========================================
- Hits 19627 19613 -14
+ Misses 20066 19244 -822
... and 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
requested review from
Razican,
jasonwilliams,
jedel1043,
nekevss,
RageKnify and
raskad
HalidOdat
force-pushed
the
fix/get-function-opcode-trace
branch
from
b12ffb4 to
6eeaabc
Compare
Test262 conformance changes
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
Fix get function opcode traces (`GetFunction`, `GetGenerator`, etc)
```js
function x() {
let y = 0;
}
```
Before:
```
000000 0000 GetFunction 0000: 'JSInternedStrRef { utf8: Some("x"), utf16: [120] }' (length: 0)
000006 0001 DefInitVar 0000: 'x'
```
After:
```
000000 0000 GetFunction 0000: 'x' (length: 0)
000006 0001 DefInitVar 0000: 'x'
```
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix get function opcode traces (
GetFunction,GetGenerator, etc)Before:
After: