[Merged by Bors] - Don't construct prototype if not needed #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
performance
HalidOdat
requested review from
raskad,
jedel1043,
jasonwilliams,
nekevss and
RageKnify
Test262 conformance changes
Fixed tests (2): |
Codecov Report
@@ Coverage Diff @@
## main #2751 +/- ##
==========================================
+ Coverage 50.30% 50.68% +0.37%
==========================================
Files 398 395 -3
Lines 40013 39736 -277
==========================================
+ Hits 20130 20141 +11
+ Misses 19883 19595 -288
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
bors r+ |
jasonwilliams
approved these changes
Mar 27, 2023
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
When the function is `async || arrow || method ` we don't need to construct the prototype (then drop it).
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the function is
async || arrow || methodwe don't need to construct the prototype (then drop it).