-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix deserialization of SpecEdition
#2762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
bug
Something isn't working
test
Issues and PRs related to the tests.
labels
Mar 29, 2023
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
nekevss
March 29, 2023 21:16
Codecov Report
@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
+ Coverage 50.96% 52.29% +1.33%
==========================================
Files 397 392 -5
Lines 40009 39021 -988
==========================================
+ Hits 20389 20405 +16
+ Misses 19620 18616 -1004 see 19 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
raskad
approved these changes
Mar 29, 2023
HalidOdat
approved these changes
Mar 29, 2023
Test262 conformance changes
Fixed tests (16):
|
All good! |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
`boa_tester` wasn't deserializing `SpecEdition` correcly. This was because the attribute `serde(untagged)` just removes the u8 tag instead of trying to deserialize as a number. This PR fixes this using the `serde_repr` crate. This needs #2763 to be merged for it to pass CI.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Fix deserialization of
[Merged by Bors] - Fix deserialization of Mar 29, 2023
SpecEdition
SpecEdition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boa_tester
wasn't deserializingSpecEdition
correcly. This was because the attributeserde(untagged)
just removes the u8 tag instead of trying to deserialize as a number. This PR fixes this using theserde_repr
crate.This needs #2763 to be merged for it to pass CI.