[Merged by Bors] - Add json-parse-with-source feature to boa_tester
#2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2778 +/- ##
=======================================
Coverage 50.98% 50.98%
=======================================
Files 409 409
Lines 40759 40759
=======================================
Hits 20780 20780
Misses 19979 19979
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jedel1043
approved these changes
Apr 3, 2023
Razican
approved these changes
Apr 3, 2023
I personally like the warning that a missing feature generates, since that forces us to add it to the list of features. Though, I can see why that could be a problem, but I'd propose to wait and see if adding new features is so common that it becomes a burden to update test262. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2023
This PR resolves the failing CI in #2777 It changes the following: - Adds `json-parse-with-source` feature to `boa_tester` - Bumps `test262` module to `be0abd9`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
json-parse-with-source feature to boa_testerjson-parse-with-source feature to boa_tester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the failing CI in #2777
It changes the following:
json-parse-with-sourcefeature toboa_testertest262module tobe0abd9