Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix ThrowTypeError intrinsic #2797

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix ThrowTypeError intrinsic #2797

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

Fixes the remaining failing tests on the ThrowTypeError test suite

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Apr 10, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 10, 2023
@github-actions
Copy link

github-actions bot commented Apr 10, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,781 94,781 0
Passed 71,211 71,219 +8
Ignored 17,824 17,824 0
Failed 5,746 5,738 -8
Panics 0 0 0
Conformance 75.13% 75.14% +0.01%
Fixed tests (8): 
test/built-ins/ThrowTypeError/property-order.js [strict mode] (previously Failed)
test/built-ins/ThrowTypeError/property-order.js (previously Failed)
test/built-ins/ThrowTypeError/name.js [strict mode] (previously Failed)
test/built-ins/ThrowTypeError/name.js (previously Failed)
test/built-ins/ThrowTypeError/frozen.js [strict mode] (previously Failed)
test/built-ins/ThrowTypeError/frozen.js (previously Failed)
test/built-ins/ThrowTypeError/extensible.js [strict mode] (previously Failed)
test/built-ins/ThrowTypeError/extensible.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #2797 (0d0cfba) into main (1e75fd0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2797   +/-   ##
=======================================
  Coverage   51.40%   51.40%           
=======================================
  Files         416      416           
  Lines       41080    41081    +1     
=======================================
+ Hits        21117    21119    +2     
+ Misses      19963    19962    -1
Impacted Files Coverage Δ
boa_engine/src/object/mod.rs 31.19% <ø> (ø)
boa_engine/src/builtins/error/type.rs 80.00% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Razican
Razican approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@HalidOdat
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Apr 10, 2023

Merge conflict.

@HalidOdat HalidOdat force-pushed the fix/throw-type-error-intrinsic branch from d75e2cb to 687a616 Compare April 10, 2023 19:30
@jedel1043
Copy link
Member

Was test262 downgraded by the rebase?

@HalidOdat HalidOdat force-pushed the fix/throw-type-error-intrinsic branch from 687a616 to 0d0cfba Compare April 10, 2023 19:42
@HalidOdat
Copy link
Member Author

Was test262 downgraded by the rebase?

Opps, fix that :)

@HalidOdat
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 10, 2023
@HalidOdat
Fix ThrowTypeError intrinsic (#2797)
09d57e7 
Fixes the remaining failing tests on the `ThrowTypeError` test suite
@bors
Copy link

bors bot commented Apr 10, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix ThrowTypeError intrinsic [Merged by Bors] - Fix ThrowTypeError intrinsic Apr 10, 2023
@bors bors bot closed this Apr 10, 2023
@bors bors bot deleted the fix/throw-type-error-intrinsic branch April 10, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

@Razican Razican Razican approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@RageKnify RageKnify Awaiting requested review from RageKnify

@nekevss nekevss Awaiting requested review from nekevss

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HalidOdat @jedel1043 @Razican @raskad