Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Implement annex-b trimLeft and trimRight string methods #2806

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Implement annex-b trimLeft and trimRight string methods #2806

wants to merge 1 commit into from

Conversation

HalidOdat
Copy link
Member

With this and #2805 , annex-b/builtins/string should have 100% conformance, also fixed the normalize method incorrect length value, which was the last failing tests in normalize test suite

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Apr 11, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone Apr 11, 2023
@github-actions
Copy link

github-actions bot commented Apr 11, 2023 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 94,781 94,781 0
Passed 71,385 71,403 +18
Ignored 17,824 17,824 0
Failed 5,572 5,554 -18
Panics 0 0 0
Conformance 75.32% 75.33% +0.02%
Fixed tests (18): 
test/annexB/built-ins/String/prototype/trimLeft/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/reference-trimStart.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/reference-trimStart.js (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/name.js (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimLeft/length.js (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/reference-trimEnd.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/reference-trimEnd.js (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/prop-desc.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/prop-desc.js (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/name.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/name.js (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/length.js [strict mode] (previously Failed)
test/annexB/built-ins/String/prototype/trimRight/length.js (previously Failed)
test/built-ins/String/prototype/normalize/length.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/length.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Merging #2806 (1563882) into main (333b94a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
+ Coverage   51.29%   51.31%   +0.01%     
==========================================
  Files         416      416              
  Lines       41197    41213      +16     
==========================================
+ Hits        21133    21149      +16     
  Misses      20064    20064
Impacted Files Coverage Δ
boa_engine/src/builtins/string/mod.rs 57.76% <100.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jedel1043
jedel1043 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Razican
Razican approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Razican
Copy link
Member

Razican commented Apr 11, 2023

bors r+

@bors
Copy link

bors bot commented Apr 11, 2023

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@HalidOdat HalidOdat force-pushed the fix/string-annex-b-trim-methods branch from adfb0b0 to 1563882 Compare April 11, 2023 05:17
@HalidOdat
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 11, 2023
@HalidOdat
Implement annex-b trimLeft and trimRight string methods (#2806)
4fbecb5 
With this and #2805 , `annex-b/builtins/string` should have 100% conformance, also fixed the `normalize` method incorrect `length` value, which was the last failing tests in `normalize` test suite
@bors
Copy link

bors bot commented Apr 11, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement annex-b trimLeft and trimRight string methods [Merged by Bors] - Implement annex-b trimLeft and trimRight string methods Apr 11, 2023
@bors bors bot closed this Apr 11, 2023
@bors bors bot deleted the fix/string-annex-b-trim-methods branch April 11, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @Razican @jedel1043