[Merged by Bors] - Add hooks to get the current time and timezone #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
Fixed tests (2): |
Codecov Report
@@ Coverage Diff @@
## main #2824 +/- ##
==========================================
+ Coverage 51.32% 51.38% +0.06%
==========================================
Files 417 417
Lines 41356 41330 -26
==========================================
+ Hits 21224 21238 +14
+ Misses 20132 20092 -40
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: Iban Eguia Moraza <razican@protonmail.ch>
|
I will try this out now and let you know |
|
I can confirm this works, all of our tests have passed. We're now on upstream Boa with this branch, and will be on main once this is merged :) Thanks so much, this is just great. |
HalidOdat
approved these changes
Apr 15, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2023
This Pull Request changes the following: - Adds two new hooks to `HostHooks` to access the current UTC time and the current timezone offset. - Replaces usages of `Local` with the host hook. - Replaces usages of `Utc::now` and `Local::now` with the hooks. cc @lastmjs
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
HostHooksto access the current UTC time and the current timezone offset.Localwith the host hook.Utc::nowandLocal::nowwith the hooks.cc @lastmjs