Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement var initializers in for-in loops #2842

Closed
wants to merge 3 commits into from

Conversation

jedel1043
Copy link
Member

This Pull Request implements Initializers in ForIn Statement Heads from the Annex B. This also cleans up the "annex-b" feature to be able to disable it with --no-default-features, since I couldn't test the error messages when the feature is disabled.

@jedel1043 jedel1043 added enhancement New feature or request parser Issues surrounding the parser vm Issues and PRs related to the Boa Virtual Machine. labels Apr 19, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Apr 19, 2023
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,591 94,591 0
Passed 73,161 73,162 +1
Ignored 17,530 17,530 0
Failed 3,900 3,899 -1
Panics 0 0 0
Conformance 77.34% 77.35% +0.00%
Fixed tests (1):
test/annexB/language/statements/for-in/nonstrict-initializer.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #2842 (0f9b268) into main (f97ad0d) will increase coverage by 0.00%.
The diff coverage is 47.94%.

@@           Coverage Diff           @@
##             main    #2842   +/-   ##
=======================================
  Coverage   50.92%   50.92%           
=======================================
  Files         419      419           
  Lines       41780    41805   +25     
=======================================
+ Hits        21278    21291   +13     
- Misses      20502    20514   +12     
Impacted Files Coverage Δ
boa_parser/src/error.rs 59.09% <0.00%> (ø)
boa_parser/src/parser/statement/if_stm/mod.rs 51.61% <0.00%> (-0.85%) ⬇️
...oa_parser/src/parser/statement/labelled_stm/mod.rs 65.21% <25.00%> (-1.45%) ⬇️
...er/src/parser/statement/iteration/for_statement.rs 55.83% <43.47%> (-1.61%) ⬇️
boa_ast/src/statement/iteration/mod.rs 43.47% <50.00%> (+5.38%) ⬆️
boa_engine/src/bytecompiler/statement/loop.rs 81.32% <63.15%> (-0.68%) ⬇️
boa_parser/src/lexer/mod.rs 79.31% <100.00%> (ø)
boa_parser/src/parser/statement/variable/mod.rs 89.23% <100.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jedel1043 jedel1043 force-pushed the for-in-initializers branch from 1cbaf98 to 0f9b268 Compare April 21, 2023 02:17
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@raskad
Copy link
Member

raskad commented Apr 23, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 23, 2023
This Pull Request implements [Initializers in ForIn Statement Heads](https://tc39.es/ecma262/#sec-initializers-in-forin-statement-heads) from the Annex B. This also cleans up the "annex-b" feature to be able to disable it with `--no-default-features`, since I couldn't test the error messages when the feature is disabled.
@bors
Copy link

bors bot commented Apr 23, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement var initializers in for-in loops [Merged by Bors] - Implement var initializers in for-in loops Apr 23, 2023
@bors bors bot closed this Apr 23, 2023
@bors bors bot deleted the for-in-initializers branch April 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parser Issues surrounding the parser vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants