Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Catch 'eval' and 'arguments' in setter method parameter #2858

Closed
wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Apr 22, 2023

This Pull Request changes the following:

  • Catch 'eval' and 'arguments' in setter method parameter

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Apr 22, 2023
@raskad raskad added this to the v0.17.0 milestone Apr 22, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 94,591 94,591 0
Passed 73,165 73,167 +2
Ignored 17,530 17,530 0
Failed 3,896 3,894 -2
Panics 0 0 0
Conformance 77.35% 77.35% +0.00%
Fixed tests (2):
test/language/expressions/object/setter-param-arguments-strict-inside.js (previously Failed)
test/language/expressions/object/setter-param-eval-strict-inside.js (previously Failed)

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #2858 (17e6dc6) into main (3db79f6) will increase coverage by 0.00%.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main    #2858   +/-   ##
=======================================
  Coverage   50.92%   50.92%           
=======================================
  Files         419      419           
  Lines       41776    41783    +7     
=======================================
+ Hits        21276    21280    +4     
- Misses      20500    20503    +3     
Impacted Files Coverage Δ
...arser/expression/primary/object_initializer/mod.rs 63.75% <25.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks good to me!

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 22, 2023
This Pull Request changes the following:

- Catch 'eval' and 'arguments' in setter method parameter
@bors
Copy link

bors bot commented Apr 22, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Catch 'eval' and 'arguments' in setter method parameter [Merged by Bors] - Catch 'eval' and 'arguments' in setter method parameter Apr 22, 2023
@bors bors bot closed this Apr 22, 2023
@bors bors bot deleted the setter-eval-arguments branch April 22, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants