-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Allow Date
object to store invalid NativeDateTime
#2861
Conversation
Date
object to store invalid datetimeDate
object to store invalid NativeDateTime
Test262 conformance changes
Fixed tests (16):
|
Codecov Report
@@ Coverage Diff @@
## main #2861 +/- ##
==========================================
+ Coverage 50.92% 50.94% +0.01%
==========================================
Files 419 419
Lines 41783 41789 +6
==========================================
+ Hits 21280 21288 +8
+ Misses 20503 20501 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
bors r+ |
Part of ES5. This PR allows `Date` objects to store an invalid `NativeDateTime` as a `i64` and check when `getMinutes` (or other methods) call and check if it's valid, like in the spec This was failing some `Date` tests, when calling `new Date(8.64e15)` then calling `getTime()` it was returning `NaN` when it should return the passed value `8640000000000000` (as node does)
Pull request successfully merged into main. Build succeeded: |
Date
object to store invalid NativeDateTime
Date
object to store invalid NativeDateTime
Part of ES5.
This PR allows
Date
objects to store an invalidNativeDateTime
as ai64
and check whengetMinutes
(or other methods) call and check if it's valid, like in the specThis was failing some
Date
tests, when callingnew Date(8.64e15)
then callinggetTime()
it was returningNaN
when it should return the passed value8640000000000000
(as node does)