-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a bunch more tests #2885
Added a bunch more tests #2885
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2885 +/- ##
==========================================
+ Coverage 51.24% 51.44% +0.20%
==========================================
Files 427 427
Lines 42522 42621 +99
==========================================
+ Hits 21790 21928 +138
+ Misses 20732 20693 -39
|
I've missed a few lines, so I will adapt the tests a bit :) |
Misses in coverage have been reported here: xd009642/tarpaulin#351 (comment) |
@HalidOdat I removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
As a follow up of #2883 and #2884, this PR changes the following:
boa_parser::error::ErrorContext
trait, to now have aset_context()
andcontext()
setter and getters for context.boa_unicode
Source