-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lexical environments in for loops #2917
Conversation
Test262 conformance changes
Fixed tests (12):
|
Codecov Report
@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
+ Coverage 51.98% 52.01% +0.02%
==========================================
Files 431 431
Lines 43647 43669 +22
==========================================
+ Hits 22690 22713 +23
+ Misses 20957 20956 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, just a couple questions/thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 😄
This Pull Request changes the following:
LexicalDeclaration
.let
bindings are used in the initializer.