Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup some bytecompiler code #2918

Merged
merged 1 commit into from
May 9, 2023
Merged

Cleanup some bytecompiler code #2918

merged 1 commit into from
May 9, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented May 9, 2023

This Pull Request changes the following:

  • Remove some unused code / arguments for method compilation functions.
  • Only push PushUndefined + Return at the end of a function if needed.
  • Remove an expect in try...catch compilation.

@raskad raskad added vm Issues and PRs related to the Boa Virtual Machine. Internal Category for changelog labels May 9, 2023
@raskad raskad added this to the v0.17.0 milestone May 9, 2023
@raskad raskad requested a review from a team May 9, 2023 01:05
@github-actions
Copy link

github-actions bot commented May 9, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,657 94,657 0
Passed 73,889 73,889 0
Ignored 17,505 17,505 0
Failed 3,263 3,263 0
Panics 0 0 0
Conformance 78.06% 78.06% 0.00%

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2918 (a429825) into main (128c137) will increase coverage by 0.01%.
The diff coverage is 23.72%.

@@            Coverage Diff             @@
##             main    #2918      +/-   ##
==========================================
+ Coverage   51.96%   51.98%   +0.01%     
==========================================
  Files         431      431              
  Lines       43662    43647      -15     
==========================================
- Hits        22691    22690       -1     
+ Misses      20971    20957      -14     
Impacted Files Coverage Δ
boa_engine/src/bytecompiler/class.rs 15.05% <0.00%> (ø)
...gine/src/bytecompiler/expression/object_literal.rs 42.85% <33.33%> (ø)
boa_engine/src/bytecompiler/mod.rs 65.78% <50.00%> (+1.22%) ⬆️
boa_engine/src/bytecompiler/function.rs 90.90% <100.00%> (+0.28%) ⬆️
boa_engine/src/bytecompiler/statement/try.rs 100.00% <100.00%> (ø)

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor!

@jedel1043 jedel1043 added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 2faa247 May 9, 2023
@jedel1043 jedel1043 deleted the bytecompiler-cleanup branch May 9, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants