-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct conversion from u8
to Opcode
#2951
Conversation
Test262 conformance changes
|
b2f4eed
to
e0b97c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2951 +/- ##
==========================================
+ Coverage 50.05% 50.40% +0.34%
==========================================
Files 446 444 -2
Lines 45975 45355 -620
==========================================
- Hits 23015 22859 -156
+ Misses 22960 22496 -464
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e0b97c4
to
279ec1a
Compare
I think we don't need We should also remove the |
279ec1a
to
bb4d02f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Optimizes opcode fetching by removing the checks that validate if it's a correct opcode. every
u8
combination matches to a validOpcode
variant (even if it's reserved).Main:
PR:
There is a small improvement in performance.