Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant param_count field from CallFrame #2962

Merged
merged 1 commit into from
May 26, 2023

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented May 25, 2023

Hopefully this is will be a PR in a series of PRs to refactor the way we call functions and in general and making it easier to implement some optimizations, breaking it down into smaller parts for easier review :)

It changes the following:

  • Remove redundant param_count field from CallFrame
  • Make pc, fp,, etc a u32.

@HalidOdat HalidOdat added performance Performance related changes and issues execution Issues or PRs related to code execution labels May 25, 2023
@HalidOdat HalidOdat added this to the v0.17.0 milestone May 25, 2023
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,990 93,990 0
Passed 74,620 74,620 0
Ignored 17,622 17,622 0
Failed 1,748 1,748 0
Panics 0 0 0
Conformance 79.39% 79.39% 0.00%

@HalidOdat HalidOdat marked this pull request as ready for review May 25, 2023 16:12
@HalidOdat HalidOdat requested a review from a team May 25, 2023 16:12
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #2962 (b2ec55c) into main (7ae8582) will decrease coverage by 0.01%.
The diff coverage is 64.93%.

@@            Coverage Diff             @@
##             main    #2962      +/-   ##
==========================================
- Coverage   50.02%   50.02%   -0.01%     
==========================================
  Files         446      446              
  Lines       45903    45896       -7     
==========================================
- Hits        22963    22959       -4     
+ Misses      22940    22937       -3     
Impacted Files Coverage Δ
boa_engine/src/vm/opcode/control_flow/return.rs 72.72% <0.00%> (ø)
boa_engine/src/vm/opcode/environment/mod.rs 53.53% <0.00%> (ø)
boa_engine/src/vm/opcode/mod.rs 45.45% <ø> (ø)
boa_engine/src/vm/opcode/templates/mod.rs 95.83% <0.00%> (ø)
boa_engine/src/vm/opcode/generator/mod.rs 13.39% <7.69%> (ø)
boa_engine/src/vm/opcode/jump/mod.rs 71.42% <40.00%> (ø)
boa_engine/src/vm/opcode/control_flow/throw.rs 83.51% <57.14%> (ø)
boa_engine/src/vm/opcode/control_flow/finally.rs 74.35% <83.33%> (+2.56%) ⬆️
boa_engine/src/vm/mod.rs 53.89% <90.90%> (+0.27%) ⬆️
boa_engine/src/vm/call_frame/mod.rs 100.00% <100.00%> (+10.52%) ⬆️
... and 9 more

... and 1 file with indirect coverage changes

Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nekevss nekevss requested a review from a team May 25, 2023 21:28
@raskad raskad added this pull request to the merge queue May 26, 2023
Merged via the queue into main with commit 15749ed May 26, 2023
@HalidOdat HalidOdat deleted the remove-unneded-call-frame-field branch May 27, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution performance Performance related changes and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants