-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneded num_bindings
in Opcode
s and CodeBlock
#2967
Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2967 +/- ##
==========================================
- Coverage 50.02% 50.01% -0.01%
==========================================
Files 446 446
Lines 45896 45906 +10
==========================================
+ Hits 22959 22961 +2
- Misses 22937 22945 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes a lot! I'd second the above review about docs. Other than that, great work! 😄
Since the number of bindings is stored in the compiled envionments and when we create the environment we pass it, there is no need to store the num_bindings for the environments
It changes the following:
function_environment_push_location
field onCodeBlock
num_bindings
field onCodeBlock
num_bindings
operand fromPushDeclarativeEnvironment
opcodenum_bindings
operand fromPushFunctionEnvironment
opcodeByteCompiler::push_compile_environment()
return only the index.num_bindings
field from environment stack methods that push environments.CodeBlock
flags tobitflags
field.