Fix prompt on windows #2986
Merged
Fix prompt on windows #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2986 +/- ##
==========================================
- Coverage 50.20% 50.20% -0.01%
==========================================
Files 446 446
Lines 45988 45993 +5
==========================================
Hits 23089 23089
- Misses 22899 22904 +5
|
By moving the prompt coloring to be done in Highlighter::highlight_prompt, we sidestep the issue on Windows where the prompt width is calculated post-coloring AND without ignoring escape codes. By including it in the implementation of Highlighter, Editor::readline now operates on a plain-text prompt, so width calculation is correct. This commit also re-arranges the trait impl order to match the definition.
ShaneEverittM
force-pushed
the
fix-prompt-on-windows
branch
from
2e2ce7b to
30e9fc2
Compare
jedel1043
added
bug
Razican
approved these changes
Jun 5, 2023
Razican
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Fix typo * Refactor prompt highlighting into RLHelper By moving the prompt coloring to be done in Highlighter::highlight_prompt, we sidestep the issue on Windows where the prompt width is calculated post-coloring AND without ignoring escape codes. By including it in the implementation of Highlighter, Editor::readline now operates on a plain-text prompt, so width calculation is correct. This commit also re-arranges the trait impl order to match the definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
Details
In rustyline, there are two implementations of
calculate_position, one for windows and one for unix. The one for unix support ignoring ANSI escape sequences when calculating width, but the one on windows does not, by design.This caused an issue where the cursor would be placed 12 columns in, instead of 3.
Before
After