Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse yield import(..) expressions #3006

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Correctly parse yield import(..) expressions #3006

merged 1 commit into from
Jun 6, 2023

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jun 6, 2023

Very small change that allows yield import(..) expressions.

@jedel1043 jedel1043 added bug Something isn't working parser Issues surrounding the parser labels Jun 6, 2023
@jedel1043 jedel1043 added this to the v0.17.0 milestone Jun 6, 2023
@jedel1043 jedel1043 requested a review from a team June 6, 2023 19:12
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,620 74,622 +2
Ignored 17,740 17,740 0
Failed 1,748 1,746 -2
Panics 0 0 0
Conformance 79.29% 79.29% +0.00%
Fixed tests (2):
test/language/expressions/dynamic-import/for-await-resolution-and-error-agen-yield.js [strict mode] (previously Failed)
test/language/expressions/dynamic-import/for-await-resolution-and-error-agen-yield.js (previously Failed)

@Razican Razican requested a review from a team June 6, 2023 19:31
@raskad raskad added this pull request to the merge queue Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3006 (08bd08f) into main (6879c59) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3006      +/-   ##
==========================================
- Coverage   50.22%   50.22%   -0.01%     
==========================================
  Files         446      446              
  Lines       46048    46049       +1     
==========================================
  Hits        23127    23127              
- Misses      22921    22922       +1     
Impacted Files Coverage Δ
...a_parser/src/parser/expression/assignment/yield.rs 33.92% <0.00%> (-0.62%) ⬇️

Merged via the queue into main with commit 9a903fb Jun 6, 2023
@jedel1043 jedel1043 deleted the yield-import branch June 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants