Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add early error for await in class static blocks #3019

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Add early error for await in class static blocks #3019

merged 1 commit into from
Jun 9, 2023

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 8, 2023

This Pull Request changes the following:

  • Add early error for await in class static blocks

@raskad raskad added bug Something isn't working parser Issues surrounding the parser labels Jun 8, 2023
@raskad raskad added this to the v0.17.0 milestone Jun 8, 2023
@raskad raskad requested a review from a team June 8, 2023 22:55
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Test262 conformance changes

Test result main count PR count difference
Total 94,108 94,108 0
Passed 74,644 74,646 +2
Ignored 17,740 17,740 0
Failed 1,724 1,722 -2
Panics 0 0 0
Conformance 79.32% 79.32% +0.00%
Fixed tests (2): 
test/language/statements/class/static-init-invalid-await.js [strict mode] (previously Failed)
test/language/statements/class/static-init-invalid-await.js (previously Failed)

@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #3019 (f7aabf1) into main (0fda681) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3019   +/-   ##
=======================================
  Coverage   50.58%   50.58%           
=======================================
  Files         446      446           
  Lines       45920    45920           
=======================================
  Hits        23230    23230           
  Misses      22690    22690
Impacted Files Coverage Δ
.../statement/declaration/hoistable/class_decl/mod.rs 50.59% <0.00%> (ø)

HalidOdat
HalidOdat approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! :)

jedel1043
jedel1043 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@jedel1043 jedel1043 added this pull request to the merge queue Jun 9, 2023
Merged via the queue into main with commit b502d25 Jun 9, 2023
@HalidOdat HalidOdat deleted the fix-await-in-class-static-block branch June 9, 2023 00:35
Razican pushed a commit that referenced this pull request Jun 26, 2023
@raskad @Razican
Add early error for await in class static blocks (#3019)
6a5c069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working parser Issues surrounding the parser
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raskad @HalidOdat @jedel1043