Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle finally..loop..break #3073

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Correctly handle finally..loop..break #3073

merged 1 commit into from
Jun 27, 2023

Conversation

dirkdev98
Copy link
Contributor

The match was too greedy, being executed for 'break' abrupt completions as well.

Closes #3054

@dirkdev98
Correctly handle finally..loop..break
22b713f 
The match was too greedy, being executed for 'break' abrupt completions as well.

Closes boa-dev#3054
@dirkdev98 dirkdev98 mentioned this pull request Jun 26, 2023
Closed
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #3073 (22b713f) into main (e96c838) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3073   +/-   ##
=======================================
  Coverage   50.43%   50.43%           
=======================================
  Files         445      445           
  Lines       45910    45910           
=======================================
  Hits        23154    23154           
  Misses      22756    22756
Impacted Files Coverage Δ
boa_unicode/src/lib.rs 66.66% <ø> (ø)
boa_engine/src/vm/opcode/control_flow/finally.rs 74.35% <100.00%> (ø)

jedel1043
jedel1043 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@jedel1043 jedel1043 requested a review from a team June 26, 2023 23:34
@jedel1043 jedel1043 added bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine. labels Jun 26, 2023
HalidOdat
HalidOdat approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@HalidOdat HalidOdat added this pull request to the merge queue Jun 27, 2023
Merged via the queue into boa-dev:main with commit 4a75b29 Jun 27, 2023
@dirkdev98 dirkdev98 deleted the fix/finally-loop-break branch June 27, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working vm Issues and PRs related to the Boa Virtual Machine.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic at break in an infinte loop, in finally block
3 participants
@dirkdev98 @HalidOdat @jedel1043