Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some optimizations on Error #4020

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Oct 17, 2024

This brings some optimizations:

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (6ddc2b4) to head (23c6c1a).
Report is 282 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/error.rs 54.83% 14 Missing ⚠️
core/engine/src/builtins/temporal/error.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4020      +/-   ##
==========================================
+ Coverage   47.24%   52.85%   +5.60%     
==========================================
  Files         476      482       +6     
  Lines       46892    46723     -169     
==========================================
+ Hits        22154    24695    +2541     
+ Misses      24738    22028    -2710     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

core/engine/src/error.rs Outdated Show resolved Hide resolved
@CrazyboyQCD CrazyboyQCD changed the title Mark JsNativeError's constructors const Some optimizations on Error Oct 22, 2024
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just needs a small fix.

core/gc/src/trace.rs Show resolved Hide resolved
Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from @jedel1043's comment LGTM

@jedel1043
Copy link
Member

@jasonwilliams you pinged a random user 😅

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@jedel1043 jedel1043 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into boa-dev:main with commit 4983471 Nov 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants