Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a display_lossy() to write a JsString lossily #4023

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Oct 24, 2024

This is faster when we don't need to keep the unpaired surrogates.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (6ddc2b4) to head (9e1e0c5).
Report is 275 commits behind head on main.

Files with missing lines Patch % Lines
core/string/src/lib.rs 0.00% 2 Missing ⚠️
core/string/src/display.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4023      +/-   ##
==========================================
+ Coverage   47.24%   52.85%   +5.61%     
==========================================
  Files         476      482       +6     
  Lines       46892    46728     -164     
==========================================
+ Hits        22154    24699    +2545     
+ Misses      24738    22029    -2709     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@jedel1043 jedel1043 requested a review from a team October 24, 2024 19:01
@jedel1043 jedel1043 added enhancement New feature or request API labels Oct 24, 2024
@jedel1043 jedel1043 added this to the next-release milestone Oct 24, 2024
@HalidOdat HalidOdat added this pull request to the merge queue Oct 25, 2024
Merged via the queue into boa-dev:main with commit acd1a8d Oct 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants