Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nightly build #4026

Merged
merged 2 commits into from
Nov 3, 2024
Merged

add nightly build #4026

merged 2 commits into from
Nov 3, 2024

Conversation

jasonwilliams
Copy link
Member

fixes #3910

@jasonwilliams jasonwilliams added the Internal Category for changelog label Nov 3, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.91%. Comparing base (6ddc2b4) to head (627328c).
Report is 281 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4026      +/-   ##
==========================================
+ Coverage   47.24%   52.91%   +5.66%     
==========================================
  Files         476      483       +7     
  Lines       46892    46893       +1     
==========================================
+ Hits        22154    24813    +2659     
+ Misses      24738    22080    -2658

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nekevss
nekevss approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

jedel1043
jedel1043 reviewed Nov 3, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, the file just needs a newline at the end 😅

@jasonwilliams jasonwilliams added this pull request to the merge queue Nov 3, 2024
Merged via the queue into boa-dev:main with commit 265dca3 Nov 3, 2024
14 checks passed
@jasonwilliams jasonwilliams deleted the generate-binaries branch November 3, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@nekevss nekevss nekevss approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@RageKnify RageKnify Awaiting requested review from RageKnify

@raskad raskad Awaiting requested review from raskad

Assignees
No one assigned
Labels
Internal Category for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish nightly artifacts
3 participants
@jasonwilliams @jedel1043 @nekevss