Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade #406

Merged
merged 3 commits into from
May 21, 2020
Merged

Dependency upgrade #406

merged 3 commits into from
May 21, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented May 19, 2020

I upgraded all dependencies both for our wasm demo and for our core in Rust. This (with some potential extra upgrades until the release) should get merged for 0.8.

@Razican Razican added the dependencies Pull requests that update a dependency file label May 19, 2020
@Razican Razican added this to the v0.8.0 milestone May 19, 2020
@Razican
Copy link
Member Author

Razican commented May 19, 2020

I found 3 issues with this:

  • text-encoding is deprecated, we should use fast-text-encoding, but it seems it's not compatible with wasm-pack.
  • copy-webpack-plugin breaks when upgrading it to ^6.0.0. This was only released 4 days ago, so it's not a big deal, but it seems it requires a change on how we configure it.
  • We have no CI whatsoever checking our WASM target, if I'm not mistaken, we should include a wasm-pack test command with maybe some tests to make sure that our WASM target builds and performs as expected.

@github-actions
Copy link

Benchmark for 838a8ea

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 376.3±20.03µs 375.6±20.38µs 100%
Expression (Lexer) 1764.3±72.08ns 1708.1±98.26ns 103%
Expression (Parser) 4.9±0.17µs 4.9±0.30µs 99%
Fibonacci (Execution) 2.6±0.14ms 2.4±0.11ms 108%
For loop (Execution) 404.1±33.42µs 401.1±17.33µs 101%
For loop (Lexer) 4.9±0.18µs 5.1±0.50µs 96%
For loop (Parser) 13.5±0.36µs 12.9±0.97µs 105%
Hello World (Lexer) 933.2±36.43ns 905.3±54.99ns 103%
Hello World (Parser) 2.2±0.08µs 2.1±0.12µs 106%
Symbols (Execution) 410.7±23.32µs 376.2±19.63µs 109.00000000000001%
undefined undefined 100%

@github-actions
Copy link

Benchmark for db54f44

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 410.3±12.47µs 421.3±13.05µs 97%
Expression (Lexer) 2.1±0.07µs 2.1±0.08µs 99%
Expression (Parser) 5.2±0.16µs 5.3±0.22µs 97%
Fibonacci (Execution) 2.9±0.09ms 2.9±0.10ms 100%
For loop (Execution) 460.8±18.23µs 457.5±18.32µs 101%
For loop (Lexer) 5.6±0.23µs 5.4±0.17µs 103%
For loop (Parser) 15.5±0.60µs 15.2±0.50µs 102%
Hello World (Lexer) 1042.4±44.73ns 1022.3±22.07ns 102%
Hello World (Parser) 2.5±0.07µs 2.6±0.09µs 96%
Symbols (Execution) 448.3±9.11µs 455.6±9.25µs 98%
undefined undefined 100%

@Razican
Copy link
Member Author

Razican commented May 21, 2020

This is ready for a merge!

@github-actions
Copy link

Benchmark for 8d895c3

Click to view benchmark
Test PR Benchmark Master Benchmark %
Create Realm 394.2±9.31µs 396.9±23.83µs 99%
Expression (Lexer) 1960.2±95.54ns 1937.5±24.50ns 101%
Expression (Parser) 5.1±0.06µs 5.3±0.19µs 96%
Fibonacci (Execution) 2.6±0.04ms 2.6±0.04ms 100%
For loop (Execution) 424.2±16.22µs 417.4±7.99µs 102%
For loop (Lexer) 5.2±0.09µs 5.2±0.08µs 100%
For loop (Parser) 14.3±0.17µs 14.3±0.43µs 100%
Hello World (Lexer) 944.6±15.26ns 926.5±9.81ns 102%
Hello World (Parser) 2.4±0.07µs 2.4±0.11µs 99%
Symbols (Execution) 418.8±6.24µs 426.2±6.19µs 98%
undefined undefined 100%

@jasonwilliams
Copy link
Member

We have no CI whatsoever checking our WASM target, if I'm not mistaken, we should include a wasm-pack test command with maybe some tests to make sure that our WASM target builds and performs as expected.

Have you made an issue for this?

@Razican
Copy link
Member Author

Razican commented May 21, 2020

We have no CI whatsoever checking our WASM target, if I'm not mistaken, we should include a wasm-pack test command with maybe some tests to make sure that our WASM target builds and performs as expected.

Have you made an issue for this?

Yep, #408.

@Razican Razican merged commit 323f486 into master May 21, 2020
@Razican Razican deleted the update_deps branch May 21, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants