-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TypeError
implementation
#442
Conversation
- Fixed `RangeError` and `Error` throwing. - Moved throwing code to Interperter. - Added throw_range_error() and throw_type_error() to Interperter.
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 66.64% 66.83% +0.19%
==========================================
Files 124 127 +3
Lines 8852 8888 +36
==========================================
+ Hits 5899 5940 +41
+ Misses 2953 2948 -5
Continue to review full report at Codecov.
|
Benchmark for df2416bClick to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments, they are mostly for my understanding.
Benchmark for eb10840Click to view benchmark
|
It changes the following:
TypeError
implementation.RangeError
andError
throwing.Interpreter
.throw_range_error()
andthrow_type_error()
toInterpreter
.Now with this PR it should be easier to throw exceptions, for example:
This is more or less the way
neon
crate does it.