-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and added test for String.prototype.concat
#538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
test
Issues and PRs related to the tests.
builtins
PRs and Issues related to builtins/intrinsics
labels
Jul 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 68.31% 68.34% +0.02%
==========================================
Files 171 171
Lines 10486 10494 +8
==========================================
+ Hits 7164 7172 +8
Misses 3322 3322
Continue to review full report at Codecov.
|
Benchmark for 1c7c066Click to view benchmark
|
Razican
approved these changes
Jul 2, 2020
HalidOdat
force-pushed
the
cleanup/string-prototype-concat
branch
from
July 2, 2020 22:38
49895f4
to
86a3a77
Compare
Benchmark for ac31798Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
concat
test case (the other one is fixed by Fix allValue
operations and add unsigned shift right #520)concat
method (as described in spec)