-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #[track_caller]
to GcObject
methods that can panic
#673
Conversation
Codecov Report
@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 73.14% 73.14%
=======================================
Files 192 192
Lines 14005 14005
=======================================
Hits 10244 10244
Misses 3761 3761
Continue to review full report at Codecov.
|
Benchmark for 24bf086Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
It changes the following:
#[track_caller]
toGcObject
methods that panic. This should make finding borrow error much easier.