-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output of Object.toString() #737
Conversation
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 71.75% 71.80% +0.05%
==========================================
Files 200 200
Lines 13983 14012 +29
==========================================
+ Hits 10033 10062 +29
Misses 3950 3950
Continue to review full report at Codecov.
|
271babb
to
0b797d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, but now that we are at it, I think we should implement it to be spec compliant:
https://tc39.es/ecma262/#sec-object.prototype.tostring
Yeah, my bad to not look for it. |
Test: Add testing of Object.toString(), need update once Function.prototype.call is implemented * not fully because Arguments Exotic Objects are not yet implemented
e3201c2
to
5e3db42
Compare
I assume one of the bugs in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side! Thanks!
Output for |
This Pull Request fixes/closes #729.
It changes the following:
Object::to_string
returns aValue::String
respecting the spec: https://tc39.es/ecma262/#sec-object.prototype.tostring