Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ast/node/expression into ast/node/call and ast/node/new #787

Merged
merged 1 commit into from
Oct 4, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Oct 4, 2020

PR instead of unmergable old #542

It makes no sense to leave these two grouped under the node expression.

@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #787 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #787   +/-   ##
=======================================
  Coverage   59.13%   59.13%           
=======================================
  Files         155      155           
  Lines        9838     9838           
=======================================
  Hits         5818     5818           
  Misses       4020     4020           
Impacted Files Coverage Δ
boa/src/syntax/ast/node/call/mod.rs 83.33% <ø> (ø)
boa/src/syntax/ast/node/new/mod.rs 72.22% <ø> (ø)
boa/src/syntax/ast/node/mod.rs 43.80% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a509de...f2930ea. Read the comment docs.

@Lan2u Lan2u self-requested a review October 4, 2020 15:16
@RageKnify RageKnify merged commit e60d081 into boa-dev:master Oct 4, 2020
@RageKnify RageKnify added this to the v0.11.0 milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants