-
-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw RangeError when BigInt division by zero occurs #790
Conversation
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
==========================================
- Coverage 59.28% 59.13% -0.16%
==========================================
Files 156 155 -1
Lines 9820 9842 +22
==========================================
- Hits 5822 5820 -2
- Misses 3998 4022 +24
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This Pull Request closes #780.
It changes the following:
Adds a check when dividing by zero to throw a RangeError if y (the right-hand expression) is
0n
.Spec: https://www.ecma-international.org/ecma-262/#sec-numeric-types-bigint-divide