Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builtin Map] Map.prototype.entries method and map iterator #847

Merged
merged 11 commits into from
Oct 15, 2020
Merged

[builtin Map] Map.prototype.entries method and map iterator #847

merged 11 commits into from
Oct 15, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Oct 11, 2020

This Pull Request fixes/closes #846

I will likely need some help.

@codecov
Copy link

codecov bot commented Oct 11, 2020 •
edited
Loading

Codecov Report

Merging #847 into master will increase coverage by 0.09%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   59.08%   59.17%   +0.09%     
==========================================
  Files         164      165       +1     
  Lines       10209    10284      +75     
==========================================
+ Hits         6032     6086      +54     
- Misses       4177     4198      +21
Impacted Files Coverage Δ
boa/src/builtins/array/mod.rs 72.70% <ø> (ø)
boa/src/builtins/mod.rs 23.52% <ø> (ø)
boa/src/object/mod.rs 46.99% <40.00%> (-0.11%) ⬇️
boa/src/builtins/map/map_iterator.rs 64.28% <64.28%> (ø)
boa/src/builtins/map/mod.rs 72.51% <88.88%> (+1.20%) ⬆️
boa/src/builtins/iterable/mod.rs 94.23% <100.00%> (+0.35%) ⬆️
boa/src/builtins/map/ordered_map.rs 63.63% <100.00%> (+2.34%) ⬆️
...x/parser/statement/iteration/do_while_statement.rs 73.91% <0.00%> (+13.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5e888...9673263. Read the comment docs.

@JohnDoneth JohnDoneth mentioned this pull request Oct 12, 2020
Closed
Razican
Razican reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it requires running rustfmt. In any case, I'm not an expert on this, maybe @HalidOdat or @RageKnify can help better :)

boa/src/builtins/iterable/mod.rs Outdated Show resolved Hide resolved
@croraf croraf marked this pull request as ready for review October 13, 2020 02:42
@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Oct 13, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 13, 2020
HalidOdat
HalidOdat reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :) Also maybe some tests would be nice

boa/src/builtins/map/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/map/ordered_map.rs Outdated Show resolved Hide resolved
@croraf croraf changed the title [builtin Map] entries method and map iterator [builtin Map] Map.prototype.entries method and map iterator Oct 13, 2020
@croraf
Added symbol_iterator method. Refactor to use exactly the same functi…
10cf5e1 
…on as "entries". Added test for it, unignored pending test.
@croraf
Copy link
Contributor Author

croraf commented Oct 13, 2020

I've added new commit which should close #810

@HalidOdat HalidOdat linked an issue Oct 13, 2020 that may be closed by this pull request
Map.prototype[@@iterator]() method not implemented #810
Closed
Razican
Razican reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a couple of TODO comments, give them a look, and from my side, it's ready to merge.

boa/src/builtins/map/map_iterator.rs Outdated Show resolved Hide resolved
boa/src/builtins/map/ordered_map.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat requested a review from Razican October 14, 2020 16:30
@croraf croraf mentioned this pull request Oct 14, 2020
Merged
@RageKnify RageKnify merged commit ce535dd into boa-dev:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RageKnify RageKnify RageKnify approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Lan2u Lan2u Awaiting requested review from Lan2u

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Map.prototype.entries() method not implemented Map.prototype[@@iterator]() method not implemented
4 participants
@croraf @Razican @HalidOdat @RageKnify