Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master CI #875

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Fix master CI #875

merged 2 commits into from
Oct 15, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 14, 2020

This should fix the CI in the master branch. We were adding an extra folder to the cache.

@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Oct 14, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 14, 2020
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #875 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #875   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files         164      164           
  Lines       10209    10209           
=======================================
  Hits         6032     6032           
  Misses       4177     4177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a295fe...403f0c0. Read the comment docs.

@github-actions
Copy link

Benchmark for c62570e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 391.5±0.43ns 378.0±0.35ns +3.57%
Arithmetic operations (Full) 240.2±3.76µs 248.6±10.15µs -3.38%
Array access (Execution) 8.2±0.02µs 8.2±0.02µs 0.00%
Array access (Full) 263.1±0.33µs 259.9±0.53µs +1.23%
Array creation (Execution) 2.9±0.00ms 2.9±0.00ms 0.00%
Array creation (Full) 3.2±0.02ms 3.2±0.00ms 0.00%
Array pop (Execution) 1083.5±4.07µs 1081.6±4.13µs +0.18%
Array pop (Full) 1542.4±1.54µs 1555.9±56.84µs -0.87%
Boolean Object Access (Execution) 4.9±0.14µs 4.8±0.01µs +2.08%
Boolean Object Access (Full) 256.2±0.51µs 252.1±1.50µs +1.63%
Clean js (Execution) 724.0±4.25µs 725.4±4.36µs -0.19%
Clean js (Full) 1037.0±7.91µs 1035.4±7.49µs +0.15%
Clean js (Parser) 38.3±0.04µs 38.2±0.06µs +0.26%
Create Realm 490.1±0.44ns 501.2±0.33ns -2.21%
Dynamic Object Property Access (Execution) 5.8±0.03µs 5.8±0.02µs 0.00%
Dynamic Object Property Access (Full) 255.7±1.43µs 253.9±1.59µs +0.71%
Expression (Parser) 7.2±0.01µs 7.3±0.01µs -1.37%
Fibonacci (Execution) 851.6±3.06µs 853.6±10.24µs -0.23%
Fibonacci (Full) 1130.1±12.59µs 1126.8±3.39µs +0.29%
For loop (Execution) 23.6±0.16µs 24.9±1.25µs -5.22%
For loop (Full) 280.0±0.62µs 278.8±0.57µs +0.43%
For loop (Parser) 19.0±0.04µs 19.0±0.11µs 0.00%
Goal Symbols (Parser) 13.0±0.03µs 12.9±0.04µs +0.78%
Hello World (Parser) 3.5±0.00µs 3.5±0.00µs 0.00%
Long file (Parser) 803.5±1.05ns 802.0±2.17ns +0.19%
Mini js (Execution) 649.0±3.66µs 650.6±3.53µs -0.25%
Mini js (Full) 933.3±3.21µs 933.1±5.11µs +0.02%
Mini js (Parser) 33.4±0.03µs 33.3±0.03µs +0.30%
Number Object Access (Execution) 3.8±0.01µs 3.8±0.01µs 0.00%
Number Object Access (Full) 261.5±22.35µs 248.2±0.36µs +5.36%
Object Creation (Execution) 5.0±0.01µs 5.0±0.01µs 0.00%
Object Creation (Full) 251.8±1.50µs 250.1±0.38µs +0.68%
RegExp (Execution) 10.0±0.05µs 10.0±0.04µs 0.00%
RegExp (Full) 261.8±0.50µs 259.5±1.78µs +0.89%
RegExp Literal (Execution) 11.3±0.03µs 11.2±0.03µs +0.89%
RegExp Literal (Full) 261.5±0.79µs 261.9±0.65µs -0.15%
RegExp Literal Creation (Execution) 10.0±0.03µs 10.0±0.04µs 0.00%
RegExp Literal Creation (Full) 255.3±1.80µs 252.7±0.32µs +1.03%
Static Object Property Access (Execution) 5.2±0.02µs 5.1±0.03µs +1.96%
Static Object Property Access (Full) 255.3±0.92µs 259.0±12.65µs -1.43%
String Object Access (Execution) 7.4±0.02µs 7.4±0.03µs 0.00%
String Object Access (Full) 257.5±0.74µs 258.2±8.54µs -0.27%
String comparison (Execution) 6.8±0.02µs 7.0±0.37µs -2.86%
String comparison (Full) 259.4±0.50µs 255.1±0.28µs +1.69%
String concatenation (Execution) 5.4±0.01µs 5.6±0.13µs -3.57%
String concatenation (Full) 250.4±1.49µs 263.1±12.05µs -4.83%
String copy (Execution) 4.2±0.02µs 4.2±0.02µs 0.00%
String copy (Full) 244.5±0.43µs 242.0±0.25µs +1.03%
Symbols (Execution) 3.6±0.01µs 3.6±0.01µs 0.00%
Symbols (Full) 234.0±0.53µs 231.2±0.30µs +1.21%

@github-actions
Copy link

Benchmark for 5ca0428

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 382.7±26.54ns 368.3±25.71ns +3.91%
Arithmetic operations (Full) 258.1±26.53µs 257.5±20.92µs +0.23%
Array access (Execution) 8.5±0.52µs 8.7±0.67µs -2.30%
Array access (Full) 279.9±20.64µs 291.4±22.56µs -3.95%
Array creation (Execution) 2.7±0.18ms 2.9±0.23ms -6.90%
Array creation (Full) 3.2±0.23ms 3.3±0.24ms -3.03%
Array pop (Execution) 1047.8±90.31µs 1022.9±91.30µs +2.43%
Array pop (Full) 1533.9±88.18µs 1657.5±127.38µs -7.46%
Boolean Object Access (Execution) 5.1±0.45µs 5.2±0.46µs -1.92%
Boolean Object Access (Full) 288.3±20.04µs 271.4±17.91µs +6.23%
Clean js (Execution) 749.0±55.04µs 743.5±99.12µs +0.74%
Clean js (Full) 1058.6±80.17µs 1042.9±71.20µs +1.51%
Clean js (Parser) 39.8±3.48µs 39.9±2.66µs -0.25%
Create Realm 504.5±39.25ns 498.1±37.57ns +1.28%
Dynamic Object Property Access (Execution) 6.4±0.47µs 6.2±0.42µs +3.23%
Dynamic Object Property Access (Full) 273.5±16.13µs 285.9±19.83µs -4.34%
Expression (Parser) 7.3±0.62µs 7.7±0.94µs -5.19%
Fibonacci (Execution) 916.5±58.31µs 933.6±67.42µs -1.83%
Fibonacci (Full) 1215.3±79.48µs 1195.5±73.60µs +1.66%
For loop (Execution) 25.9±2.10µs 24.9±1.84µs +4.02%
For loop (Full) 319.8±24.15µs 299.5±24.69µs +6.78%
For loop (Parser) 19.4±1.61µs 20.0±1.57µs -3.00%
Goal Symbols (Parser) 13.4±1.16µs 12.8±0.87µs +4.69%
Hello World (Parser) 3.5±0.24µs 3.6±0.29µs -2.78%
Long file (Parser) 817.0±53.48ns 870.2±117.91ns -6.11%
Mini js (Execution) 651.1±47.33µs 655.9±52.86µs -0.73%
Mini js (Full) 949.6±63.47µs 968.2±71.59µs -1.92%
Mini js (Parser) 36.1±2.98µs 34.6±2.26µs +4.34%
Number Object Access (Execution) 4.0±0.28µs 4.1±0.32µs -2.44%
Number Object Access (Full) 306.1±58.02µs 278.3±22.70µs +9.99%
Object Creation (Execution) 5.2±0.33µs 5.5±0.37µs -5.45%
Object Creation (Full) 279.5±20.81µs 267.9±20.67µs +4.33%
RegExp (Execution) 10.4±0.81µs 10.4±0.83µs 0.00%
RegExp (Full) 291.4±21.78µs 271.6±17.93µs +7.29%
RegExp Literal (Execution) 11.5±0.86µs 11.1±0.73µs +3.60%
RegExp Literal (Full) 299.5±24.76µs 297.3±22.28µs +0.74%
RegExp Literal Creation (Execution) 9.9±0.79µs 10.7±0.69µs -7.48%
RegExp Literal Creation (Full) 283.7±23.01µs 273.3±20.79µs +3.81%
Static Object Property Access (Execution) 5.5±0.44µs 5.6±0.38µs -1.79%
Static Object Property Access (Full) 276.3±16.32µs 268.7±19.11µs +2.83%
String Object Access (Execution) 7.4±0.48µs 7.5±0.52µs -1.33%
String Object Access (Full) 274.2±19.49µs 279.8±21.61µs -2.00%
String comparison (Execution) 7.1±0.56µs 6.8±0.39µs +4.41%
String comparison (Full) 282.1±21.64µs 272.4±16.68µs +3.56%
String concatenation (Execution) 5.6±0.40µs 6.2±0.49µs -9.68%
String concatenation (Full) 273.5±19.92µs 270.8±20.76µs +1.00%
String copy (Execution) 4.4±0.30µs 4.5±0.34µs -2.22%
String copy (Full) 273.9±33.18µs 261.5±17.23µs +4.74%
Symbols (Execution) 3.8±0.29µs 3.7±0.24µs +2.70%
Symbols (Full) 259.3±18.57µs 246.9±17.85µs +5.02%

@Lan2u Lan2u self-requested a review October 15, 2020 07:52
@Lan2u Lan2u merged commit ab5e888 into master Oct 15, 2020
@Razican Razican deleted the fix_doc_upload branch October 19, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants