Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded rustyline and test262 #952

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Upgraded rustyline and test262 #952

merged 1 commit into from
Dec 3, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Dec 3, 2020

It seems that the new rustyline requires a new "derive" version, but dependabot was opening PRs with one or the other being updated, so they were failing. This fixes that and also updates the test262 module.

@Razican Razican added dependencies Pull requests that update a dependency file test Issues and PRs related to the tests. labels Dec 3, 2020
@Razican Razican added this to the v0.11.0 milestone Dec 3, 2020
@Razican Razican changed the title Upgraded dependencies and test262 Upgraded rustyline and test262 Dec 3, 2020
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

Test262 conformance changes:

Test result master count PR count difference
Total 78,415 78,460 +45
Passed 18,953 18,964 +11
Ignored 15,547 15,559 +12
Failed 43,915 43,937 +22
Panics 1,127 1,127 0
Conformance 24.17 24.17 +0.00%

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #952 (7196ee7) into master (c5c804d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #952   +/-   ##
=======================================
  Coverage   59.18%   59.18%           
=======================================
  Files         166      166           
  Lines       10561    10561           
=======================================
  Hits         6251     6251           
  Misses       4310     4310           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c804d...c972984. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

Benchmark for 7196ee7

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 362.7±22.99ns 360.9±11.62ns +0.50%
Arithmetic operations (Full) 273.5±42.51µs 260.3±19.06µs +5.07%
Array access (Execution) 9.3±1.27µs 9.3±1.13µs 0.00%
Array access (Full) 288.9±14.74µs 286.6±19.24µs +0.80%
Array creation (Execution) 2.9±0.19ms 2.9±0.25ms 0.00%
Array creation (Full) 3.2±0.35ms 3.0±0.06ms +6.67%
Array pop (Execution) 1042.8±68.24µs 1092.2±174.53µs -4.52%
Array pop (Full) 1587.7±140.48µs 1507.1±37.45µs +5.35%
Boolean Object Access (Execution) 5.2±0.11µs 5.1±0.15µs +1.96%
Boolean Object Access (Full) 274.6±13.72µs 271.9±16.30µs +0.99%
Clean js (Execution) 765.4±33.65µs 777.7±86.59µs -1.58%
Clean js (Full) 1119.6±102.35µs 1087.9±73.84µs +2.91%
Clean js (Parser) 39.8±2.68µs 38.6±1.79µs +3.11%
Create Realm 497.4±23.73ns 494.1±17.27ns +0.67%
Dynamic Object Property Access (Execution) 6.2±0.28µs 6.2±0.21µs 0.00%
Dynamic Object Property Access (Full) 279.8±10.94µs 275.3±13.49µs +1.63%
Expression (Parser) 7.0±0.34µs 7.0±0.41µs 0.00%
Fibonacci (Execution) 972.7±67.32µs 953.8±59.41µs +1.98%
Fibonacci (Full) 1281.9±108.27µs 1272.6±64.08µs +0.73%
For loop (Execution) 24.5±1.77µs 24.6±1.85µs -0.41%
For loop (Full) 307.3±20.90µs 303.0±14.45µs +1.42%
For loop (Parser) 19.6±1.47µs 19.2±1.71µs +2.08%
Goal Symbols (Parser) 12.8±0.52µs 12.9±0.46µs -0.78%
Hello World (Parser) 3.5±0.35µs 3.5±0.13µs 0.00%
Long file (Parser) 823.5±37.85ns 816.5±35.71ns +0.86%
Mini js (Execution) 700.2±76.26µs 682.7±19.60µs +2.56%
Mini js (Full) 995.0±91.87µs 969.7±61.43µs +2.61%
Mini js (Parser) 34.9±2.35µs 33.3±0.82µs +4.80%
Number Object Access (Execution) 4.0±0.13µs 4.0±0.20µs 0.00%
Number Object Access (Full) 276.7±20.17µs 266.4±10.51µs +3.87%
Object Creation (Execution) 5.5±0.74µs 5.3±0.18µs +3.77%
Object Creation (Full) 275.5±9.62µs 275.0±14.89µs +0.18%
RegExp (Execution) 11.5±0.46µs 11.3±0.43µs +1.77%
RegExp (Full) 296.5±41.65µs 284.0±34.75µs +4.40%
RegExp Literal (Execution) 11.6±0.88µs 11.4±0.70µs +1.75%
RegExp Literal (Full) 293.0±11.71µs 298.6±20.90µs -1.88%
RegExp Literal Creation (Execution) 10.3±1.49µs 10.1±0.47µs +1.98%
RegExp Literal Creation (Full) 290.1±31.54µs 276.6±11.59µs +4.88%
Static Object Property Access (Execution) 5.5±0.24µs 5.6±0.24µs -1.79%
Static Object Property Access (Full) 278.4±16.54µs 278.2±24.23µs +0.07%
String Object Access (Execution) 7.9±0.27µs 7.9±0.74µs 0.00%
String Object Access (Full) 278.3±10.83µs 284.4±9.43µs -2.14%
String comparison (Execution) 7.1±0.38µs 7.0±0.18µs +1.43%
String comparison (Full) 280.2±13.58µs 280.3±36.11µs -0.04%
String concatenation (Execution) 5.8±0.41µs 6.1±1.08µs -4.92%
String concatenation (Full) 275.4±15.08µs 272.6±18.32µs +1.03%
String copy (Execution) 4.5±0.41µs 4.4±0.16µs +2.27%
String copy (Full) 267.5±9.39µs 262.7±12.54µs +1.83%
Symbols (Execution) 4.1±0.19µs 4.2±0.54µs -2.38%
Symbols (Full) 261.5±13.89µs 261.5±20.37µs 0.00%

@Razican Razican merged commit 939d97d into master Dec 3, 2020
@Razican Razican deleted the rustyline_upgrade branch December 3, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant