Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement add & subtract methods for DateTime component #45

Merged
merged 2 commits into from
May 20, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented May 19, 2024

This PR implements the add and subtract method and support to the DateTime component.

In sum this Pull Request:

  • Implements Add & Subtract methods on DateTime
  • Implements AddDateTime (add_date_duration) to the IsoDateTime struct.
  • Fixes a bug related to NormalizeTimeDuration
  • Adds a couple tests for the above

This functionality will be needed for the upcoming updates to the Duration method algorithms (related to #19).

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss merged commit a2d6518 into main May 20, 2024
5 checks passed
@nekevss nekevss deleted the add-subtract-datetime branch May 20, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants