Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overflowing when calling NormalizedTimeDuration::add_days #61

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Avoid overflowing when calling NormalizedTimeDuration::add_days #61

merged 1 commit into from
Jun 25, 2024

Conversation

jedel1043
Copy link
Member

Eagerly convert to i128, which avoids overflowing when days * NS_PER_DAY is too big.

@jedel1043 jedel1043 added C-bug Something isn't working C-internal Internal library improvements labels Jun 25, 2024
@jedel1043 jedel1043 merged commit 4efa8c9 into main Jun 25, 2024
5 checks passed
@jedel1043 jedel1043 deleted the add-days-overflow branch June 25, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@raskad raskad Awaiting requested review from raskad

Assignees
No one assigned
Labels
C-bug Something isn't working C-internal Internal library improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedel1043 @nekevss