Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random setup #134

Merged
merged 4 commits into from
Mar 9, 2018
Merged

Fix random setup #134

merged 4 commits into from
Mar 9, 2018

Conversation

Stefan-Hanke
Copy link
Contributor

Fixes #133

@nicolodavis Please check whether initial is correctly initialized. initial.ctx.random now contains PRNGState.get() after setup has been evaluated. The true initial state would be not running anything (no setup either), and then having one state that evaluates setup.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis nicolodavis merged commit ed09f51 into boardgameio:master Mar 9, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b44af72 on Stefan-Hanke:fix-random-setup into c6a9bdf on google:master.

sedobrengocce pushed a commit to sedobrengocce/boardgame.io that referenced this pull request Mar 21, 2018
@Stefan-Hanke @nicolodavis
Fix random setup (boardgameio#134)
e6651b3 
* set seed before calling setup()

* drop console.log; drop unnecessary condition

* fix PRNGState initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stefan-Hanke @coveralls @nicolodavis @darthfiddler