Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix display of log with phased game #135

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

philihp
Copy link
Contributor

@philihp philihp commented Mar 8, 2018

I think the debug log pane is busted for games with multiple phases. You can demo this if you look up the phases game in examples http://localhost:8000/#/phases and turn on the log window. This quick fix sort of gets it operational, but it still gets messed up if you mouseover past history. I'm kind of drunk sorry ballmer peak doesn't help with sentence structure.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling edd767a on philihp:philihp--logview into c6a9bdf on google:master.

@nicolodavis nicolodavis merged commit c50d5ea into boardgameio:master Mar 9, 2018
@philihp philihp deleted the philihp--logview branch March 9, 2018 19:42
sedobrengocce pushed a commit to sedobrengocce/boardgame.io that referenced this pull request Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants