Python Bot base class (#98)

[francoijs]

• Add example for a TicTacToe bot

Checklist

• Use a separate branch in your local repo (not master).
• Test coverage is 100% (or you have a story for why it's ok).

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[coveralls]

Coverage remained the same at 100.0% when pulling bab5e03 on francoijs:master into b5028ab on google:master.

[francoijs]

CLA signed!

[googlebot]

CLAs look good, thanks!

[nicolodavis]

The semantics of actionPlayers is that any player in the set is allowed to play. So you should be checking if:

self.bot.player_id in actionPlayers

instead of just looking at the first value

[vdfdev]

Great work! How are you planning to connect this with the javascript backend?

EDIT: nevermind I realize you connect using socket io! That's great! It is a much simpler solution than what I was thinking! Kudos :D

[nicolodavis]

@francoijs Looks great! I have some minor formatting fixes etc. that I can add to your branch directly if you open up permissions on it.

Also, would you mind adding some unit tests for the base class? (the JS code in this repo has 100% coverage, so it would be a bit jarring for Python to have 0%).

[nicolodavis]

Also, please add *.pyc to the .gitignore file (again, happy to do these things myself if you open up permissions).

[francoijs]

Thanks for the review! You should now be collaborator on my fork of boardgame.io, is it enough so that you can modify the PR?
BTW, the PR was made directly on master instead of a separate branch, I hope it's not a problem.
I will be glad to add some unit-tests, but it may take some time since I will be off for the next 2 weeks.

[nicolodavis]

No worries that it's directly on master. Yep, I think that should allow me to modify the PR.

[nicolodavis]

@francoijs Can you run pylint on your code and fix the warnings?