Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated games list test to be more useful #216

Merged
merged 1 commit into from
Jun 9, 2018

Conversation

jorbascrumps
Copy link
Contributor

@jorbascrumps jorbascrumps commented Jun 8, 2018

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

I didn't feel like the test for games list was particularly useful as it didn't actually test what we're interested in testing. Now the test checks to ensure that the returned list contains the names of available games.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jorbascrumps
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c3effc4 on iamchristopher:fix-games-list-test into b4bb3cd on google:master.

@nicolodavis nicolodavis merged commit b19b403 into boardgameio:master Jun 9, 2018
@nicolodavis
Copy link
Member

Thanks!

@jorbascrumps jorbascrumps deleted the fix-games-list-test branch June 9, 2018 18:05
amitport pushed a commit to amitport/boardgame.io that referenced this pull request Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants