Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename playerCredentials to credentials for /leave endpoint #416

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Rename playerCredentials to credentials for /leave endpoint #416

merged 1 commit into from
Jun 6, 2019

Conversation

jasonharrison
Copy link
Contributor

Rename playerCredentials to credentials for /leave endpoint per @nicolodavis #414 (comment).

Update src/lobby/connection.js accordingly.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

nicolodavis
nicolodavis approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@nicolodavis nicolodavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason!

@nicolodavis nicolodavis merged commit 89faece into boardgameio:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolodavis nicolodavis nicolodavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonharrison @nicolodavis