Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No payload is not an authentic player #430

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

blunket
Copy link
Contributor

@blunket blunket commented Jul 9, 2019

This fixes #410. Unless that issue is way more complex than I thought.

Sorry I been gone for a while. Still want to help a lot with this repo. 😄

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis
Copy link
Member

Welcome back @blunket!

This PR does indeed fix the case where a player tries to force their way through in an authenticated game by merely removing the payload.

However, I think we might also be inadvertently disallowing moves when the game doesn't require authentication in the first place.

@blunket
Copy link
Contributor Author

blunket commented Jul 12, 2019

Thanks for the review @nicolodavis, didn't think about that. Hopefully this update fixes that issue. I simply moved the code down a few lines in both files. haha

I didn't squash, I figured you'd squash if you wanted to! Let me know if it still needs fixing.

@nicolodavis
Copy link
Member

Perfect. Thanks a lot Andrew!

@nicolodavis nicolodavis merged commit fd70ed5 into boardgameio:master Jul 16, 2019
@blunket blunket deleted the NoPayloadNoDeal branch August 19, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isActionFromAuthenticPlayer allows moves without credentials if payload is missing
2 participants