Increment current player at start of phase in TurnOrder.DEFAULT #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would close #517
Changes
TurnOrder.DEFAULT
will now increment the current player at the start of a phase and includes a check to prevent incrementing if the phase is a game’s starting phase.Adds
TurnOrder.CONTINUE
to provide the old default behaviour for those who need it. Is this a good name? I couldn’t think of anything clearer that would still be concise.Breaking Changes
This change will break current behaviour for anyone:
TurnOrder.DEFAULT
directly or not setting a customturn.order.first
Migration
If currently using the default turn order directly, use
TurnOrder.CONTINUE
instead:If currently not setting a turn order (and using phases), import
TurnOrder
: