fix(core): Fix EndPhase deltalog #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A side effect of calling EndPhase() is an automatic call to EndTurn(). Both endPhase and endTurn log entries are added to deltalog. When the user mouses over LogEntries in the Debug Panel, the state is regenerated/reduced from the deltalogs. EndPhase() *again* makes an automatic call to EndTurn(), and then the endTurn in the deltalog is also called, resulting in one-too-many calls to EndTurn(). This issue affects games using DEFAULT turn order and causes playback fail when using the Debug:Log Panel. This error is generated to the browser console: ERROR: disallowed move: MYMOVENAME where MYMOVENAME is the name of the move that fails. Appears to correct issue boardgameio#810 Issue also reported: * 2020-06-23 07:05 - https://gitter.im/boardgame-io/General?at=5ef1f017b8152d34845bace8 * 2020-07-08 02:16 - https://gitter.im/boardgame-io/General?at=5f05778fc7d15f7d0f7b1e01
delucis
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side effect of calling
EndPhase()is an automatic call toEndTurn(). LogEntries forendPhaseandendTurnlog entries are added todeltalog.When the user mouses over
LogEntriesin the Debug Panel, the state is regenerated/reduced from the deltalogs.EndPhase()again makes an automatic call toEndTurn(), and then theendTurnin thedeltalogis also called, resulting inone-too-many calls to
EndTurn().This issue affects games using
DEFAULTturn order and causes playback fail when using theDebug:LogPanel.This error is generated to the browser console:
where MYMOVENAME is the name of the move that fails.
Appears to correct issue #810
Issue also reported: